This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Refactor of Zend\Db\Metadata for 3.0.0#369
Open
arueckauer wants to merge 14 commits intozendframework:3.0.0from
arueckauer:refactor/zend-db-metadata
Open
Refactor of Zend\Db\Metadata for 3.0.0#369arueckauer wants to merge 14 commits intozendframework:3.0.0from arueckauer:refactor/zend-db-metadata
Zend\Db\Metadata for 3.0.0#369arueckauer wants to merge 14 commits intozendframework:3.0.0from
arueckauer:refactor/zend-db-metadata
Conversation
Member
|
This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at laminas/laminas-db#13. |
Member
|
This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides changes described in #365
A few questions came up while refactoring. Some feedback is appreciated:
ColumnObjectandConstraintKeyObject). Since there are fluent setters, possibility is that they are being used. Therefore I recommend to unify and make all setters fluent. If that is okay, I'll provide the changes in this scope.ConstraintKeyObjectandAbstractSourceare used. Currently the visibility is defined aspublic. If they are not needed elsewhere,privateorprotectedmight be more suitable.$tableparameter ofloadConstraintData()andloadConstraintReferences()in classZend\Db\Metadata\Source\AbstractSourceis unused. Version 3.0 might be a good time to remove it (causing BC). Should I include this change in this scope?